GitHub as source #61
Open
GitHub as source #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakanb
reviewed
Dec 20, 2024
|
|
||
| This is a sample command that will copy the data from the GitHub source to DuckDB. | ||
|
|
||
| <img alt="athena_img" src="../media/github.png" /> |
There was a problem hiding this comment.
this says athena, I guess not?
Comment on lines
+145
to
+146
| elif self.source_scheme == "github": | ||
| return GitHubSource() |
There was a problem hiding this comment.
I think you need to rebase this
| repo = source_fields.get("repo") | ||
| if not repo: | ||
| raise ValueError( | ||
| "repo: name of the repository is required to connect with GitHub" |
There was a problem hiding this comment.
Suggested change
| "repo: name of the repository is required to connect with GitHub" | |
| "repo variable is required to fetch the data for a specific repository from GitHub" |
| ) | ||
| else: | ||
| raise ValueError( | ||
| "fResource '{table}' is not supported for GitHub source yet, if you are interested in it please create a GitHub issue at https://github.com/bruin-data/ingestr" |
There was a problem hiding this comment.
Suggested change
| "fResource '{table}' is not supported for GitHub source yet, if you are interested in it please create a GitHub issue at https://github.com/bruin-data/ingestr" | |
| f"Resource '{table}' is not supported for GitHub source yet, if you are interested in it please create a GitHub issue at https://github.com/bruin-data/ingestr" |
|
|
||
| URI parameters: | ||
|
|
||
| - `access_token`: Access Token used for authentication with the GitHub API |
There was a problem hiding this comment.
does GitHub require access token for public repositories? if not, then I suggest stating that here.
also, if token is not required for public please add an integration test in main_test.py file for this endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below changes are made in this PR: