Setup release process #179
Conversation
|
@jcoeltjen Please give this a thorough look. It seems to work now, but maybe some things are done in an unusual way or are unnecessary. |
sigiesec
force-pushed
the
setup-release-process
branch
from
10626b3 to
3039457
Compare
| # used by a subsequent build and overwrite the tag | ||
| git checkout $TRAVIS_BRANCH | ||
|
|
||
| DEVELOPMENT_VERSION=$(python -c 'version = tuple(map(int, ("'${RELEASE_VERSION}'".split(".")))); print("%i.%i.%i" % (version[0], version[1]+1, 0))') |
There was a problem hiding this comment.
Why do you use python here when you you sed in all other places?
There was a problem hiding this comment.
My sed knowledge is quite limited. I copied the sed expression from somewhere, but I wrote this myself ;) In addition, I think incrementing a number is not straight-forward with sed.
|
|
||
| cd com.btc.serviceidl.plainjava && mvn versions:set -DnewVersion=${BASE_VERSION}${BRANCH_FRAGMENT}${SNAPSHOT_FRAGMENT} | ||
|
|
||
| mvn deploy -DskipTests |
There was a problem hiding this comment.
mvn deploy could be moved outside the if/else because it is executed in both branches.
There was a problem hiding this comment.
Yes, if release:perform is not used, this could be done.
There was a problem hiding this comment.
I will leave it at is it for now. Maybe #181 will change this again.
| SNAPSHOT_FRAGMENT="-SNAPSHOT" | ||
| BASE_VERSION=`mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | sed -n -e '/^\[.*\]/ !{ /^[0-9]/ { p; q } }' | sed -e 's/-SNAPSHOT//'` | ||
|
|
||
| if [ "$TRAVIS_PULL_REQUEST" == "false" ] ; then |
There was a problem hiding this comment.
Why is this checked here?
Is the deploy.sh script even executed on pull request builds and if yes, why?
| BRANCH_FRAGMENT="-pr${TRAVIS_PULL_REQUEST}" | ||
| fi | ||
|
|
||
| cd com.btc.serviceidl.plainjava && mvn versions:set -DnewVersion=${BASE_VERSION}${BRANCH_FRAGMENT}${SNAPSHOT_FRAGMENT} |
There was a problem hiding this comment.
Why do you build the new version from multiple fragments?
Is is not possible to use RELEASE_VERSION or DEVELOPMENT_VERSION for this?
There was a problem hiding this comment.
This was not changed as part of this PR, it was only moved into the if and the indentation was changed.
RELEASE_VERSION and DEVELOPMENT_VERSION are not set at all in this block.
| BRANCH_FRAGMENT="" | ||
| cp .travis.settings.xml $HOME/.m2/settings.xml | ||
|
|
||
| if [[ "$TRAVIS_BRANCH" =~ ^release/ ]] ; then |
There was a problem hiding this comment.
Is TRAVIS_BRANCH set if building a PR?
If not you can skip the check in line 55
There was a problem hiding this comment.
Yes it is set for PR builds: "for builds triggered by a pull request this is the name of the branch targeted by the pull request."
|
@jcoeltjen What in particular do you think is overly complicated and smells like it could be simplified? |
sigiesec
force-pushed
the
setup-release-process
branch
from
3039457 to
1fd7d73
Compare
Fixes #74