Set default endpoints based on API key #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR sets default endpoints based on the API key to support InsightHub integration.
Key changes:
- Added unit tests for hub-specific notify, session, and build endpoints.
- Updated the Configuration class to set endpoints based on whether the API key starts with "00000".
- Updated the CHANGELOG and modified the test workflow to skip PHP 8.4 tests pending investigation of a deprecation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ConfigurationTest.php | Added tests to verify hub-specific endpoint defaults. |
| src/Configuration.php | Introduced hub endpoint constants and logic to select endpoints. |
| CHANGELOG.md | Documented the enhancement for API key based endpoint defaults. |
| .github/workflows/test-package.yml | Commented out PHP 8.4 tests pending further deprecation investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Set default endpoints based on API key. If no endpoint is configured, payloads should be sent to *.insighthub.smartbear.com if the API key starts with
00000.Changeset
The unit tests have started failing with PHP 8.4 before this change due to a language deprecation. A ticket has been raised to investigate that further.
Testing
Unit tests added and I've run some manual tests locally with an example app, verifying that the requested host is as expected for different API keys.