update floating point comparison tests#304
Merged
berlotti merged 2 commits intodevelopmentfrom Jun 3, 2024
Merged
Conversation
removed attribute and property tests using fixed 1e6 tolerance, replaced with relative precision (according to #294)
remove omitted tests with a fixed tolerance
Member
Author
|
For easier checking, here is the list of tests that were added: All 36 tests are based on Property, none on Attribute facet. I thought it's unnecessary to duplicate, but if you think we need both, I can add another 36 tests just on Attributes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed attribute and property tests using fixed 1e6 tolerance, replaced with relative precision (according to #294 and #78)