Incorporate ALS fixes (IVS-186)

[civilx64]

1. Upgrade to newer version of ifcopenshell to avoid bug in ALS016 related to clothoid spirals in imperial units.

2. Adjust for the total length of vertical segments so that ALS017 checks are performed correctly.

(IVS-186, IVS-53)

[Ghesselink]

• Can you check whether you checked out the right commit from development? The updates made in the ALB012 branch are modified along with these commits.
• I'm getting passed results for ALS017. Could this be that this has to do with the ifcopenshell version? I see the latest release of IfcOpenShell is 0.8.0, where do I find 0.8.1?

Edit; I've manually updated my conda environment to python3.12 and ifcopenshell commit 92b63a0, but still with the same result :(

[Ghesselink]

This should be
context.scenario_outcome_state.append((len(context.gherkin_outcomes)-1, {'scenario': context.scenario.name, 'last_step': context.scenario.steps[-1], 'instance_id': instance_id}))
See also

ifc-gherkin-rules/features/steps/validation_handling.py

Line 254 in e9f4441

context.scenario_outcome_state.append((len(context.gherkin_outcomes)-1, {'scenario': context.scenario.name, 'last_step': context.scenario.steps[-1], 'instance_id': instance_id}))

[civilx64]

The commit you noted, afdc400, was applied but my merge of ALB012 stomped over it. I have cherry-picked it back to the top of the log as 8c75bee:

[Ghesselink]

Suggested change

context.instance_outcome_state = {}

We're not using instance_outcome_state anywhere, can be deleted.

[Ghesselink]

As long as my English teacher from middle school doesn't see this .. oops

[Ghesselink]

There are still some schema errors regarding the conversion. I'll also have a look

(e.g. for pass-als017-scenario01-imperial_continuous.ifc)

[civilx64]

I'm getting passed results for ALS017. Could this be that this has to do with the ifcopenshell version? I see the latest release of IfcOpenShell is 0.8.0, where do I find 0.8.1?

Edit; I've manually updated my conda environment to python3.12 and ifcopenshell commit 92b63a0, but still with the same result :(

Per slack discussion, you need to update the .venv on your local copy of the platform which you can do with the makefiles in validate/34be62b94106d96d00b723e3b1e2fef32effb6af

[Ghesselink]

Per slack discussion, you need to update the .venv on your local copy of the platform which you can do with the makefiles in validate/34be62b94106d96d00b723e3b1e2fef32effb6af

Yes, indeed. I thought I was not using venv anymore as I switched to have my own conda environment for running the server, but didn't realize venv was still running for the worker