PB-1068 refactor 1: Replace addRepositoryHostToSSHKnownHosts with StrictHostKeyChecking=accept-new #3676
+283
−489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies SSH host key verification by using OpenSSH's
StrictHostKeyChecking=accept-newoption instead of running ssh-keyscan before git operations.The new approach is important reducing our reliance on Git binary, making it slightly easier for my subsequent git abstraction PR.
One important note is this PR raises our minimum SSH version requirement to ~2017. You can vote yes or no 🙂 .
Context
part of PB-1068
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
LLM powered this time