SUP-3241 - Revert explicit default provider_settings, keep fixes to slug logic
#856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logic (buildkite#607)" This reverts commit e01cbb0.
petetomasik
changed the title
provider_settings, keep fixes to slug logicprovider_settings, keep fixes to slug logic
tomowatt
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the changes to
provider_settingsbrought in via PR #607 and released in version v1.15.5. Will revisitprovider_settingsmanagement at a later time when additional functionality is enabled in our GraphQL API.Keeps the fixes implemented to ensure the
slugattribute is correctly reconciled with state, whether user-defined or derived from the API.