Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.7.x] more ci related backports #1293

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

chenbh
Copy link
Contributor

@chenbh chenbh commented Jul 26, 2023

Similar to #1289, but with an additional commits to:

  • stop building the build-waiter image
  • fix the secrets that are used in the e2e tests

Test run: https://github.com/buildpacks-community/kpack/actions/runs/5671406232

chenbh and others added 4 commits July 25, 2023 16:17
because we're getting weird behaviour when testing with a local
registry:2 where it won't let us delete manifests by tag. so we're now
explictly storing and deleting the actual digest of the image we create

Co-authored-by: Tom Kennedy <[email protected]>
it seems that we were relying on a race condition of another job logging
into docker before we push/relocate the lifecycle image

Signed-off-by: Bohan Chen <[email protected]>
this was a copy-paste mistake from 0.8.0+

Signed-off-by: Bohan Chen <[email protected]>
this is a minimal copy of d636723 to
get the e2e tests working

Signed-off-by: Bohan Chen <[email protected]>
@chenbh chenbh requested a review from a team as a code owner July 26, 2023 18:12
@codecov-commenter
Copy link

Codecov Report

Merging #1293 (33749c0) into release/v0.7.x (b860d33) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           release/v0.7.x    #1293   +/-   ##
===============================================
  Coverage           67.90%   67.90%           
===============================================
  Files                 122      122           
  Lines                6861     6861           
===============================================
  Hits                 4659     4659           
  Misses               1827     1827           
  Partials              375      375           

@chenbh chenbh merged commit 908e0e0 into release/v0.7.x Jul 26, 2023
2 checks passed
@chenbh chenbh deleted the 0.7.x-ci-cherrypicks branch July 26, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants