FIXME: re-worked PushImage function to exec the docker cli, or convert other docker helpers to using the client library. #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satyazzz123 <[email protected]>
Author
|
@natalieparellano I have raised a PR for docker.go FIXME . Please have a look. Thank you |
Signed-off-by: satyazzz123 <[email protected]>
| } | ||
| } | ||
| // Append the new DOCKER_CONFIG to the filtered environment | ||
| newEnv := append(filteredEnv, "DOCKER_CONFIG="+auth) |
Member
There was a problem hiding this comment.
Ah, I think auth here is a JSON encoded string, whereas docker expects the location of a directory containing a config.json file. If you look further up to where auth is constructed it should be possible to find that directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reworked PushImage function to exec the docker cli, or convert other docker helpers to using the client library.
Release notes
Related
Resolves #914
Context
This PR addresses the FIXME comment by directly executing the Docker CLI to push the image