Skip to content

Conversation

@kryjomskiDev
Copy link

No description provided.

@thomassth thomassth mentioned this pull request Jun 29, 2022
@dwenderf
Copy link

dwenderf commented Jul 5, 2022

Does anything further need to be done in order to have this reviewed/merged?

@thomassth
Copy link
Contributor

thomassth commented Jul 8, 2022

Does anything further need to be done in order to have this reviewed/merged?

Sorry got a lot on my plate right now

It looks good, but I think we also need tests
Or at least add this function into the demo app so we can test manually

I might have some free time next week, or if it works in demo I can approve it

@dwenderf
Copy link

Thanks for getting back to me Thomas!
Agreed that testing is a good idea. We're currently testing in our app, and once we are sure everything is working right, we'll either add unit tests or add to the demo app. However I can say that we are finding some strange behavior with retrieving recurring events using the plugin. Very often, events that are recurring on my Google calendar are coming back with null for recurring event rule in the plugin. We'll continue to investigate to see if we can determine if there is any particular condition that causes this to occur.

@thomassth thomassth added tests & examples enhancement New feature or request help wanted This issue is open for someone to pick up and action and removed tests & examples labels Sep 26, 2022
@thomassth
Copy link
Contributor

I have doubts on the interoperability. Changing a single event in Google calendar does not reflect on originalInstanceTime. Perhaps they are using other values?

@thomassth
Copy link
Contributor

Also it seems that your branch does not allow maintainers to add commits.

If you can't modify access on the branch, I can send it to you.

@dwenderf
Copy link

dwenderf commented Oct 9, 2022

Acutally it looks like PR #435 accomplishes this and more. It may be better to focus on that PR since it includes other enhacements as well.

@thomassth
Copy link
Contributor

#435 cramped too many thing into a single commit, and it is too difficult for anyone to check against.

Instead, I'd prefer using this, and if 435 has better approach on this specific issue, incorporate that here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted This issue is open for someone to pick up and action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants