-
Notifications
You must be signed in to change notification settings - Fork 317
Fix Gradle configuration for modern Android compatibility #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crmado
wants to merge
12
commits into
builttoroam:develop
Choose a base branch
from
crmado:fix-gradle-issues
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.3 Release
* parseRecurrenceRuleString() when else fix. * Fixed failing test (dart analyze). * Bumped version and updated changelog. --------- Co-authored-by: Shreyas S <[email protected]> Co-authored-by: Julius Bredemeyer <[email protected]>
* packages cleanup * changelog * flutter_timezone
…am#519) * Request FullAccess on iOS17+ (builttoroam#497) * fix: request FullAccess on iOS17 or later * update iOS integration description * fix: iOS build test & Android build test * feat: update xcode-version * update changelog and pubspec * fix ci --------- Co-authored-by: MIYANARI Junki <[email protected]>
Add ashwani commit adding namespace to the release version for compatibility whit AGP 8.0+
* fix github actions * another script * permissions * use env-var instead * reposition keys * typo * v4.3.3pre * v4.3.3-20240801 * tag change * fix pipeline runs * remove broken job * update kotlin versions * update kotlin versions
IVLIVS-III
requested changes
Mar 28, 2025
Contributor
IVLIVS-III
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all compiled output, i.e. all files from example/android/app/.cxx
Author
|
@IVLIVS-III I have removed all the edit output files in example/android/app/.cxx directory, please see the latest commit. Thank you for your review and suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When using the latest Flutter and Gradle versions, the original plugin has the following issues:
Solution
This PR makes the following changes:
test
It has been tested on Android 13 devices and the example app can be compiled and run normally.