Chore/worker convert #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the deployment process and improves type safety in the codebase by removing legacy configuration files and enhancing API response typings. Key changes include:
- Consolidating legacy environment configurations into a unified wrangler.jsonc file.
- Updating deployment scripts and removing obsolete files.
- Adding explicit TypeScript type annotations in API response handling to improve clarity and safety.
Reviewed Changes
Copilot reviewed 13 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/features/staking/lib/utils/keybase-client.ts | Added explicit type annotation for the API response (using any). |
| src/features/staking/lib/core/gas.ts | Introduced explicit typing for the gas API response. |
| src/features/staking/lib/core/base.ts | Added type annotations for API responses in getInflation and getDistributionParams. |
| src/config.ts | Removed unused testnet configuration. |
| server/index.ts | Added a default 404 response handler. |
| postcss.config.js | Reordered plugin configuration for readability. |
| next.config.mjs | Simplified configuration by removing legacy proxy setup and development-only logic. |
| .deploy/testnet2/wrangler.toml | Removed legacy deployment config file. |
| .deploy/testnet/wrangler.toml | Removed legacy deployment config file. |
| .deploy/mainnet/wrangler.toml | Removed legacy deployment config file. |
Files not reviewed (5)
- .deploy/mainnet/.env: Language not supported
- .deploy/testnet/.env: Language not supported
- .deploy/testnet2/.env: Language not supported
- package.json: Language not supported
- wrangler.jsonc: Language not supported
Comments suppressed due to low confidence (1)
src/features/staking/lib/core/base.ts:144
- Avoid double-casting the JSON response. Instead, create a dedicated interface for the distribution parameters response to improve clarity and enforce type checks.
const data = await response.json() as unknown as { params: { base_proposer_reward: string; bonus_proposer_reward: string; community_tax: string; withdraw_addr_enabled: boolean; }; };
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
staking-mainnet | bb3a461 | Apr 30 2025, 10:28 PM |
Deploying staking-mainnet with
|
| Latest commit: |
bb3a461
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba6a85c7.staking-mainnet-8sr.pages.dev |
| Branch Preview URL: | https://chore-worker-convert.staking-mainnet-8sr.pages.dev |
Deploying staking-testnet with
|
| Latest commit: |
bb3a461
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17351bc1.staking-testnet.pages.dev |
| Branch Preview URL: | https://chore-worker-convert.staking-testnet.pages.dev |
Deploying staking-testnet2 with
|
| Latest commit: |
bb3a461
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5904a49.staking-testnet2.pages.dev |
| Branch Preview URL: | https://chore-worker-convert.staking-testnet2.pages.dev |
burnt-sun
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to streamline the deployment process, remove deprecated configurations, and improve type safety in the codebase. The most notable updates include the removal of configurations for the
xion-testnet-1environment, the migration of deployment settings to a newwrangler.jsoncfile, and updates to type annotations for improved type safety.Deployment and Configuration Updates:
.envandwrangler.tomlfiles formainnet,testnet, andtestnet2deployments, consolidating configuration management. (.deploy/mainnet/.env,.deploy/mainnet/wrangler.toml,.deploy/testnet/.env,.deploy/testnet/wrangler.toml,.deploy/testnet2/.env,.deploy/testnet2/wrangler.toml) [1] [2] [3] [4] [5] [6]wrangler.jsoncfile to centralize deployment settings, including environment-specific variables and routes formainnetandtestnet.Codebase Simplification:
package.json. Updated deployment scripts to usewranglerdirectly. (package.json) [1] [2] [3]next.config.mjsby removing proxy-related rewrites and unusedsetupDevPlatforminitialization. (next.config.mjs) [1] [2]Type Safety Improvements:
getInflation,getDistributionParams, andestimateGasViaRestto reduce runtime errors. (src/features/staking/lib/core/base.ts,src/features/staking/lib/core/gas.ts) [1] [2] [3]getIdentityLogofunction to use a typedidparameter for better clarity. (src/features/staking/lib/utils/keybase-client.ts)Environment Cleanup:
xion-testnet-1environment, including its chain ID, RPC URLs, and asset endpoints. (src/config.ts) [1] [2] [3] [4]These changes collectively simplify the deployment process, improve maintainability, and enhance code reliability.