fix: show error indication for APR when API calls fail #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
justinbarry
commented
Jun 3, 2025
justinbarry
commented
- Remove fallback values (42% inflation, 2% community tax) from API error handlers
- Display em dash (—) instead of incorrect APR when data fails to load
- Prevent misleading APR values from being shown to users
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
staking-mainnet | 9a0a83c | Visit preview | Jun 03 2025, 12:28 AM |
- Remove fallback values (42% inflation, 2% community tax) from API error handlers - Display em dash (—) instead of incorrect APR when data fails to load - Prevent misleading APR values from being shown to users
justinbarry
force-pushed
the
fix/apr-error-handling
branch
from
103312e to
9a0a83c
Compare
burnt-sun
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.