Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/class props #26

Merged
merged 3 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/tailwind-buddy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ export const setupCompose = <Sc extends string>(
.forEach((cls) => classSet.add(cls));
}

if (props?.class) {
cleanString(props.class)
.split(" ")
.forEach((cls) => classSet.add(cls));
}

const result = mergeClasses(uniquifyClasses(Array.from(classSet)));
variantCache.set(cacheKey, result);
return result;
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/types/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export type MergedProps<
R extends ResponsiveVariants<V>
> = {
className?: string;
class?: string;
} & {
[K in keyof V]?: R extends undefined
? keyof V[K]
Expand Down
22 changes: 11 additions & 11 deletions packages/core/tests/configs/specific.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe("test simple config", () => {
root({
size: "xxs",
fontWeight: "regular",
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
disabled: true,
})
).toBe(root_full_str);
Expand All @@ -34,7 +34,7 @@ describe("test simple config", () => {
root({
size: "xxs",
fontWeight: "regular",
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
disabled: false,
})
).toBe(root_full_str);
Expand All @@ -53,13 +53,13 @@ describe("test simple config", () => {
root({
size: "xxs",
fontWeight: "bold",
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
disabled: false,
})
).toBe(root_full_str);
});

test.skip("start working with responsive props but no array condition", () => {
test("start working with responsive props but no array condition", () => {
const root_full_str = [
"inline-flex",
"font-weight-bold",
Expand All @@ -78,12 +78,12 @@ describe("test simple config", () => {
md: "xxl",
},
fontWeight: "bold",
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
})
).toBe(root_full_str);
});

test.skip("start working with responsive props and array condition", () => {
test("start working with responsive props and array condition", () => {
const root_full_str = [
"inline-flex",
"font-weight-bold",
Expand All @@ -102,12 +102,12 @@ describe("test simple config", () => {
initial: "bold",
md: "extraBold",
},
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
})
).toBe(root_full_str);
});

test.skip("start working with two responsive props and array condition", () => {
test("start working with two responsive props and array condition", () => {
const root_full_str = [
"inline-flex",
"font-weight-bold",
Expand All @@ -131,12 +131,12 @@ describe("test simple config", () => {
initial: "bold",
md: "extraBold",
},
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
})
).toBe(root_full_str);
});

test.skip("start working with two responsive props and array condition", () => {
test("start working with two responsive props and array condition", () => {
const root_full_str = [
"inline-flex",
"font-weight-bold",
Expand All @@ -162,7 +162,7 @@ describe("test simple config", () => {
initial: "bold",
md: "extraBold",
},
className: "bg-color-scheme-literal-red-500",
class: "bg-color-scheme-literal-red-500",
disabled: true,
})
).toBe(root_full_str);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/tests/setup/specific.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,4 @@ export const labelVariants = compose({
class: ["opacity-200"],
},
],
})();
})<LabelProps>();
1 change: 1 addition & 0 deletions packages/documentation/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.vitepress/cache
13 changes: 6 additions & 7 deletions packages/documentation/pages/responsive-variants.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ editLink: true

# Responsive Variants

**IMPORTANT**: If you are not using any responsive variants you can just not use all this configuration.

To enable responsive variants:

1. Add the variant to the `responsiveVariants` array in your compose function.
Expand All @@ -18,20 +20,17 @@ export const buttonVariants = compose({
})();

// Usage in a React component
import { twMerge } from "tailwind-merge";

// class .font-bold will be applied as the condition is fulfilled.
export const Button: React.FC<{}> = () => {
const { root } = buttonVariants;

return (
<button
className={twMerge(
root({
intent: "primary",
size: large,
})
)}
className={root({
intent: "primary",
size: large,
})}
>
Go
</button>
Expand Down
6 changes: 3 additions & 3 deletions packages/documentation/pages/slots.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export const Card = () => {
const { root, header, body } = cardVariants;

return (
<div className={twMerge(root({ size: "large" }))}>
<div className={twMerge(header({ size: "large" }))}>header</div>
<div className={twMerge(body())}>body</div>
<div className={root({ size: "large" })}>
<div className={header({ size: "large" })}>header</div>
<div className={body()}>body</div>
</div>
);
};
Expand Down
10 changes: 4 additions & 6 deletions packages/documentation/pages/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ export const buttonVariants = compose({
export type ButtonProps = VariantsProps<typeof buttonVariants>;

// Usage in a React component
import { twMerge } from "tailwind-merge";

export const Button: React.FC<React.PropsWithChildren<ButtonProps>> = ({
as: Component = "button",
Expand All @@ -54,16 +53,15 @@ export const Button: React.FC<React.PropsWithChildren<ButtonProps>> = ({

return (
<Component
className={twMerge(
root({
className={root({
intent: {
initial: "primary",
md: "secondary",
},
size,
className,
})
)}
{/* className, we do support class and className props. In case you use both class will be the last one in terms of position */}
class: className,
})}
{...restProps}
>
{children}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const Button: React.FC<ButtonProps> = ({
<button
className={root({
appearance,
className,
class: className,
size,
variant,
})}
Expand Down
3 changes: 1 addition & 2 deletions packages/ui/src/components/Dumb.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { compose } from "../tailwind-buddy-interface";
import React from "react";
import { twMerge } from "tailwind-merge";

export const fooVariants = compose({
slots: {
Expand Down Expand Up @@ -33,5 +32,5 @@ export const fooVariants = compose({

export const Dumb: React.FC<any> = () => {
const { root } = fooVariants;
return <div className={twMerge(root())}>Hello</div>;
return <div className={root()}>Hello</div>;
};
Loading