Split shortcuts by platform and name them #789
+105
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
force-pushed
the
name-default-shortcuts-rebase
branch
from
93ebe4f
to
d6e6c9c
Compare
lukemelia
force-pushed
the
name-default-shortcuts-rebase
branch
from
d6e6c9c
to
069865e
Compare
|
CI failures are related to sauce labs credentials |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and modernization of @hpohlmeyer's #591.
Our use case is that we need to unregister the default toggleLink commands to replace them with our own more sophisticated link editing UI.
Note that before this PR, both Mac and Windows-style shortcuts worked on both platforms. After this PR, Mac gets standard mac shortcuts (mostly Command + ...) and other platforms get standard Windows shortcuts (mostly Ctrl + ...). I think this is preferable and makes the code clearer. However, if this change is not desirable, I can revise this PR to only add names and not split commands by platform.