-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add addPath
option
#57
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
pkg/transform/testdata/expected/test4/4/Proposals/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
title: Proposals | ||
slug: README.md | ||
lastmod: 'TODO: Allow testing last mod .Origin.LastMod' | ||
--- | ||
|
||
[RelLink](../README.md) | ||
|
||
[RelLink](../Team/doc.md) | ||
|
||
This should not work: [RelLink](../../test.md) | ||
|
||
--- | ||
|
||
Found a typo, inconsistency or missing information in our docs? Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/README.md) :heart: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
--- | ||
title: Group Handbook | ||
cascade: | ||
- _target: | ||
path: /** | ||
type: docs | ||
--- | ||
|
||
Yolo | ||
|
||
[RelLink](Proposals/README.md) | ||
|
||
[RelLink](Team/doc.md) | ||
|
||
![Image](logo.png) | ||
|
||
![Image](images/logo2.png) | ||
|
||
![Outside](../../../../main.go) | ||
|
||
--- | ||
|
||
Found a typo, inconsistency or missing information in our docs? Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/README.md) :heart: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# Some Doc | ||
|
||
[RelLink](#some-doc) | ||
|
||
[RelLink](../README.md#group-handbook) | ||
|
||
[RelLink](../Proposals/README.md) | ||
|
||
--- | ||
|
||
Found a typo, inconsistency or missing information in our docs? Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/doc.md) :heart: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
weight: 100000 | ||
--- | ||
|
||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
version: 1 | ||
|
||
inputDir: "testdata/testproj" | ||
outputDir: "testdata/tmp/test4/4" | ||
|
||
gitIgnored: true | ||
|
||
transformations: | ||
|
||
- addPath: _index.md | ||
frontMatter: | ||
template: | | ||
weight: 100000 | ||
|
||
- glob: "README.md" | ||
path: README.md | ||
frontMatter: | ||
template: | | ||
title: "{{ .Origin.FirstHeader }}" | ||
|
||
cascade: | ||
- type: "docs" | ||
_target: | ||
path: "/**" | ||
backMatter: | ||
template: | | ||
Found a typo, inconsistency or missing information in our docs? | ||
Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/{{ .Origin.Filename }}) :heart: | ||
|
||
- glob: "**/README.md" | ||
frontMatter: | ||
template: | | ||
title: "{{ .Origin.FirstHeader }}" | ||
lastmod: "TODO: Allow testing last mod .Origin.LastMod" | ||
slug: "{{ .Target.FileName }}" | ||
backMatter: | ||
template: | | ||
Found a typo, inconsistency or missing information in our docs? | ||
Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/{{ .Origin.Filename }}) :heart: | ||
|
||
|
||
- glob: "**.md" | ||
backMatter: | ||
template: | | ||
Found a typo, inconsistency or missing information in our docs? | ||
Help us to improve [Thanos](https://thanos.io) documentation by proposing a fix [on GitHub here](https://github.com/thanos-io/thanos/edit/main/docs/{{ .Origin.Filename }}) :heart: | ||
|
||
- glob: "**" | ||
path: "/../4static/**" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work, but I think I am not a fan of this approach. This is a little bit mix of functionalities. We do go through transformations and we don't transform any old things here. Also why the only frontmatter if the whole file is empty? Also where the new file is put? In provided path? What if we want to provide a file next to another file we traverse?
I think it will be unwise to abstract all Linux commands within the transform configuration ): It's so easy to create this file with simple
echo ... > file
.One functionality which would be harder with Linux commands (harder than 3 words) is to add certain file content next to another file we traverse with glob 🤔
I think I would prefer something simple for now like
ExtraFiles
withcontent
template or something like this 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a new file, with just frontmatter, was the use case I was aiming to fulfill with this, as seen here in Thanos.
Yes, it is put in the provided path. For putting a new file next to a particular file we traverse, I think we can just mention path of the file we want to place it next to...but yes,
addPath
cannot work with glob.Yes, I see your point. Will try to make this simpler with
ExtraFiles
andcontent
! 🙂