feat: disconnect with properties#915
Open
kelvincesar wants to merge 4 commits intobytebeamio:mainfrom
Open
Conversation
…properties - Implemented disconnect and try_disconnect with properties. Created a handle function for async and sync code; - Updated fn handle_incoming_packet to handle a disconnect object; - Moved disconnect default reason to client file; - Updated enum Request::Disconnect to accept Disconnect struct.
kelvincesar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
disconnect_with_propertiesandtry_disconnect_with_propertiesmethods onClientandAsyncClient, allowing disconnection from the broker with custom properties and reasons.It should resolve #887.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.