Fix: MQTTv5 keep-alive duration <= 5 sec allowed #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the minimum requirement of 5 seconds of keep-alive for MQTTv5.
Additionally, the case where the keep-alive is 0 is implemented for MQTTv5 as described in the standard.
The duration is now set with u16 instead of Duration as discussed in #964.
It is similar to pull request #655 which changed the minimum requirement and 0-case handling.
Issue: #964
Attribute: This PR adds support for this in MQTTv5, following the approach used in @danieldougherty 's implementation for MQTTv4 in PR #655.
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.