-
Notifications
You must be signed in to change notification settings - Fork 68
Clarify more concisely how concepts relate to each other #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify more concisely how concepts relate to each other #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance, i thought this acted almost as a table of contents; however, as it references non-design pages, this should maybe live elsewhere
@itowlson @kate-goldenring should this be rebased/merged or closed? |
I think we should still add this in as a TOC for the design section. This needs to be rebased, filenames updated, and this added to |
@itowlson can we revisit this and see if we can fit in this glossary? It is a great overview for someone who is learning what WASI, WIT and the component model are. I think the |
@itowlson what are your thoughts on moving this to the Introduction page (almost as a preface to help readers know where to go with these new terms in their lexicon)? |
@kate-goldenring I feel like it might be overwhelming in the intro - create the feeling of "you have to know these before you can read the book" possibly. I am no longer quite sure where it would go though. It could possibly be kludged in on the "why the component model" page, even though it's more "what" than why, perhaps? |
Maybe this should go under the Reference section under a new definitions page? |
This is a great addition--I think the introduction is the right place for this, since these terms are ultimately critical vocabulary for understanding what follows. |
00770e6
to
c770005
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com> Co-authored-by: itowlson <ivan.towlson@fermyon.com>
c770005
to
160ebed
Compare
Hey @kate-goldenring @itowlson I've taken a stab at updating this PR and also adding the new information to the Introduction -- thoughts? |
@vados-cosmonic Thanks for picking up this languishing PR! However, my objection to putting it in the introduction remains the one I mentioned in #64 (comment) - I feel like this is simply too much to absorb on a page that may be readers' first encounter with the book. The paradox of it is like if you know what these things are and how they fit together, you don't need it; and if you don't know, then it scares you with half a dozen things explained in terms of each other. And so I am not sure if it is a set of signposts (at the beginning of the concepts section, giving you context for the things you're about to run into) or a recap (at the end of the concepts section, drawing it all together). Or super-vague brainstorm alert maybe it's not (only) a recap. Maybe the pages of the concepts section include the relevant pointers. Like end the "components" page with a boxout along the lines of: Want to know...
(sorry I know these are bad) and that way the reader can maybe form a sense of the relationships as they navigate around rather than having to take them in all at once. (And maybe we keep a document like this as a recap so that readers can review and confirm their understanding, and can revisit to refresh their understanding in one place.) Sorry I know I am being vague and indecisive on this. The above is very much thinking out loud and I realise it wombles off in a different direction. Maybe we are indeed better off just getting it in and iterating. |
Thanks for the thoughts here! At the very least we've got an updated section and a rebased PR, so hopefully we're one step closer to merging!
This gives me a thought -- what about actually this information part of a new section header? Something like "How the component model works" or "Concepts", and having the current sections ("components", "WIT", etc) be subsections under that? This information would be a good start/overview to a "concepts" section. That's kind of like a recap (a precap?) |
@vados-cosmonic That seems well worth exploring! When you say "a new section header," are you thinking e.g. a new page after "Why the Component Model", and then the bullets from the current PR absorbed into a more prosey, explanatory style kind of thing? |
Yup! Something like:
We do our section headers a bit inconsistently right now but this is the rough idea of what the left hand side menu would look like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM. I defer to @itowlson as to whether the placement is appropriate
Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
@vados-cosmonic Your proposed structure looks promising to me. My bullets will certainly need expanding to make it work but I feel much more comfortable with that than with having them in the intro. @kate-goldenring if you're not sick to death of this issue what do you reckon? |
I feel like the WIT reference it different from the other sections in that it is quite stand alone and not a conceptual explainer rather a reference.
|
Hey @kate-goldenring that certainly looks good to me! Will rework this PR to match that layout. IMO we do have a References section where the WIT reference should probably go, but IMO we should also have a separate introduction to WIT (more "why" and "what" than "how"), but that's for another day :) |
b428739
to
5ba5832
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
5ba5832
to
be9909d
Compare
I've made the changes! Hopefully we can take a quick look at it in the meeting soon and merge this :) |
Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Fixes #59.