fix(ems): avoid abort in gc_migrate when heap metadata is corrupted#4862
Merged
lum1n0us merged 1 commit intobytecodealliance:mainfrom Mar 5, 2026
Merged
fix(ems): avoid abort in gc_migrate when heap metadata is corrupted#4862lum1n0us merged 1 commit intobytecodealliance:mainfrom
lum1n0us merged 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: zhenweijin <zhenwei.jin@intel.com>
lum1n0us
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When app heap lives inside linear memory (e.g. heap_offset=0), wasm code
can overwrite HMU headers. During
memory.grow, gc_migrate walks theheap and may read a corrupted size, causing cur to overshoot end. The
bh_assert(cur == end)then aborts the process.Make the integrity checks unconditional in
gc_migrate: validate sizebefore advancing (size <= 0 || size > remaining) and cur == end after
the walk. Return GC_ERROR instead of asserting.