wasm-smith: add --module-shape option. #2255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2250 and the key changes are summarized as follows:
module_shape
into wasm-smith which automatically disablesavailable_imports
andexports
when enabled;wasmparser::Validator
for type information, as the _required_exports does, would introduce the inconvenient step of converting CoreTypeId back to ModuleIndex. To avoid this, this function directly copies the entire type section from the shape module to the target module, which also aligns with the implementation of _arbitrary_imports_from_available;Please feel free to share any suggestions/concerns.