Skip to content

fix(bindgen): futures and stream are not Clone #12155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rvolosatovs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(bindgen): futures and stream are not Clone #12155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/wit-bindgen/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ pub struct TypeInfo {

/// Whether or not this type (transitively) has a handle.
pub has_handle: bool,

/// Whether or not this type (transitively) has a future or a stream.
pub has_future_or_stream: bool,
}

impl std::ops::BitOrAssign for TypeInfo {
Expand All @@ -35,6 +38,7 @@ impl std::ops::BitOrAssign for TypeInfo {
self.error |= rhs.error;
self.has_list |= rhs.has_list;
self.has_handle |= rhs.has_handle;
self.has_future_or_stream |= rhs.has_future_or_stream;
}
}

Expand Down Expand Up @@ -153,6 +157,7 @@ impl Types {
}
TypeDefKind::Future(ty) | TypeDefKind::Stream(ty) => {
info = self.optional_type_info(resolve, ty.as_ref());
info.has_future_or_stream = true;
}
TypeDefKind::Handle(_) => info.has_handle = true,
TypeDefKind::Resource => {}
Expand Down Expand Up @@ -183,10 +188,10 @@ impl Types {

impl TypeInfo {
pub fn is_copy(&self) -> bool {
!self.has_list && !self.has_handle
!self.has_list && !self.has_handle && !self.has_future_or_stream
}

pub fn is_clone(&self) -> bool {
!self.has_handle
!self.has_handle && !self.has_future_or_stream
}
}