Migrate the wasmtime crate to wasmtime_environ::error::*
#12231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
force-pushed
the
migrate-wasmtime-to-wasmtime-error
branch
from
a6c7162 to
9b06a14
Compare
Instead of `anyhow::Error`.
This commit re-exports the `wasmtime_environ::error` as the `wasmtime::error`
module, updates the prelude to include these new error-handling types, redirects
our top-level `wasmtime::{Error, Result}` re-exports to re-export
`wasmtime::error::{Error, Result}`, and updates various use sites that were
directly using `anyhow` to use the new `wasmtime` versions.
This process also required updating the component macro and wit-bindgen macro to
use the new error types instead of `anyhow`.
Part of bytecodealliance#12069
fitzgen
force-pushed
the
migrate-wasmtime-to-wasmtime-error
branch
from
9b06a14 to
0b4fae7
Compare
fitzgen
changed the title
wasmtime crate to wasmtime_internal_error::Errorwasmtime crate to wasmtime_environ::error::*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
anyhow::Error.This commit re-exports
wasmtime_environ::erroras thewasmtime::errormodule, updates the prelude to include these new error-handling types, redirects our top-levelwasmtime::{Error, Result}re-exports to re-exportwasmtime::error::{Error, Result}, and updates various use sites that were directly usinganyhowto use the newwasmtimeversions.This process also required updating the component macro and wit-bindgen macro to use the new error types instead of
anyhow.Part of #12069