Skip to content

s390x: Emit instructions for bitwise FP ops #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theotherjimmy wants to merge 1 commit into
base: main
Choose a base branch
from
+80 −0
Open

s390x: Emit instructions for bitwise FP ops #12232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cranelift/codegen/src/isa/s390x/lower.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,10 @@
(rule (lower (has_type (vr128_ty ty) (bnot x)))
(vec_not ty x))

;; Float version using vector NOR.
(rule 5 (lower (has_type (ty_scalar_float _) (bnot x)))
(vec_not $F64X2 x))

;; With z15 (bnot (bxor ...)) can be a single instruction, similar to the
;; (bxor _ (bnot _)) lowering.
(rule 3 (lower (has_type (and (mie3_enabled) (fits_in_64 ty)) (bnot (bxor x y))))
Expand Down Expand Up @@ -1033,6 +1037,10 @@
(rule 0 (lower (has_type (vr128_ty ty) (band x y)))
(vec_and ty x y))

;; And two float registers, using vector overlay.
(rule 11 (lower (has_type (ty_scalar_float _) (band x y)))
(vec_and $F64X2 x y))

;; Specialized lowerings for `(band x (bnot y))` which is additionally produced
;; by Cranelift's `band_not` instruction that is legalized into the simpler
;; forms early on.
Expand Down Expand Up @@ -1075,6 +1083,10 @@
(rule 0 (lower (has_type (vr128_ty ty) (bor x y)))
(vec_or ty x y))

;; Or two floating registers, using vector overlay
(rule 11 (lower (has_type (ty_scalar_float _) (bor x y)))
(vec_or $F64X2 x y))

;; Specialized lowerings for `(bor x (bnot y))` which is additionally produced
;; by Cranelift's `bor_not` instruction that is legalized into the simpler
;; forms early on.
Expand Down Expand Up @@ -1114,6 +1126,10 @@
(rule 0 (lower (has_type (vr128_ty ty) (bxor x y)))
(vec_xor ty x y))

;; Xor two floating registers, using vector overlay
(rule 9 (lower (has_type (ty_scalar_float _) (bxor x y)))
(vec_xor $F64X2 x y))

;; Specialized lowerings for `(bxor x (bnot y))` which is additionally produced
;; by Cranelift's `bxor_not` instruction that is legalized into the simpler
;; forms early on.
Expand Down
64 changes: 64 additions & 0 deletions cranelift/filetests/filetests/isa/s390x/bitwise.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,3 +1076,67 @@ block0(v0: i32x4, v1: i32x4):
; vnx %v24, %v24, %v25
; br %r14

function %bnot_f64(f64) -> f64 {
block0(v0: f64):
v1 = bnot v0
return v1
}

; VCode:
; block0:
; vno %v0, %v0, %v0
; br %r14
;
; Disassembled:
; block0: ; offset 0x0
; vno %v0, %v0, %v0
; br %r14

function %band_f64(f64, f64) -> f64 {
block0(v0: f64, v1: f64):
v2 = band v0, v1
return v2
}

; VCode:
; block0:
; vn %v0, %v0, %v2
; br %r14
;
; Disassembled:
; block0: ; offset 0x0
; vn %v0, %v0, %v2
; br %r14

function %bor_f64(f64, f64) -> f64 {
block0(v0: f64, v1: f64):
v2 = bor v0, v1
return v2
}

; VCode:
; block0:
; vo %v0, %v0, %v2
; br %r14
;
; Disassembled:
; block0: ; offset 0x0
; vo %v0, %v0, %v2
; br %r14

function %bxor_f64(f64, f64) -> f64 {
block0(v0: f64, v1: f64):
v2 = bxor v0, v1
return v2
}

; VCode:
; block0:
; vx %v0, %v0, %v2
; br %r14
;
; Disassembled:
; block0: ; offset 0x0
; vx %v0, %v0, %v2
; br %r14