Wip gc get source dest zones #2
Conversation
| for(auto ext_it : existFile->extents_) { | ||
|
|
||
| ZoneExtent* extent; | ||
| extent = ext_it; |
There was a problem hiding this comment.
It seems that extent and ext_it are the same thing. Should we use a single identifier for both of them?
There was a problem hiding this comment.
The code may not be the latest. I did some modifications to it.
| Zone* zone_idx = extent->zone_; | ||
| //only care about the FULL zone. | ||
| if(!zone_idx->IsFull()) { | ||
| break; |
There was a problem hiding this comment.
I have no background about this project, but I doubt this logic. If one zone of an extent is already full, shall we ignore all following extents? If I guess correctly, we should use continue here.
There was a problem hiding this comment.
It is my code, continue is correct so far,.
Zifeng would help to fix it.
…ZenFS: CamelCase; Add some small modifications.
AlvinYangZF
force-pushed
the
wip_gc_get_source_dest_zones
branch
from
a9b593e to
b15721d
Compare
typo of get source zones for GC set allocate zone for GC as no life time class clang-format-11 the code style = file
AlvinYangZF
force-pushed
the
wip_gc_get_source_dest_zones
branch
from
b901bde to
37f8637
Compare
|
The patch is too big for a PR. It contains many more style changes than actual changes. I guess you have run "clang-format" with a different config, and run it again with current config. I suggest reverting latest commit in your branch and re-format it, so as to reduce size of this patch. |
Add two functions to find GC source zones and GC dest zones.