Fix issue with broken comment refresh. #1095
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlysseFG
changed the title
nafiz1001
reviewed
Jan 14, 2026
Comment on lines
165
to
+172
| useEffect(() => { | ||
| Promise.all(lane.datasets.map(async (dataset) => { | ||
| const response = await dispatch(api.datasets.get(dataset.datasetID)) | ||
| return response.data | ||
| })) | ||
| .then((values) => { | ||
| setDatasets(values as Dataset[])}) | ||
| }, [dispatch, lane.datasets]) | ||
| }, [dispatch, lane.datasets, datasetsById]) |
Collaborator
There was a problem hiding this comment.
datasetsById isn't even being directly accessed in this function. So it's a magical and suspicious fix.
Collaborator
Author
There was a problem hiding this comment.
It used to be that way before i separated that part away during an attempt at optimization 11 months ago ...
The idea is to keep an eye on the store for updated datasets (when adding a comment you update the local store version of the dataset. Not very magic ... The fix tried to only use the local store version for the refresh ... but for some reason only the changed dataset was being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.