Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lineage backend #286

Merged
merged 68 commits into from
Jun 6, 2022
Merged

Lineage backend #286

merged 68 commits into from
Jun 6, 2022

Conversation

nafiz1001
Copy link
Contributor

@nafiz1001 nafiz1001 commented May 17, 2022 •
edited
Loading

image

nafiz1001 added 28 commits May 13, 2022 11:14
@nafiz1001
create graph.js and export Tree class
8f4991e
@nafiz1001
add Lineage section with JSON visualization
df4433e
@nafiz1001
produce nodes and edge objects for React Flow
5b8118c
@nafiz1001
implement with react-d3-graph
32be41d
@nafiz1001
make Lineage a component
88e951d
@nafiz1001
add React.StrictMode
d7c58e5
@nafiz1001
add and use Lineage tab
2e75d05
@nafiz1001
use map.flat instead of reduce
b5eba8c
@nafiz1001
empty list instead of undefined
72df7a6
@nafiz1001
create and use SampleDetailsLineage.js
65629bd
@nafiz1001
don't display id
64da437
@nafiz1001
make current node red
0c399ce
@nafiz1001
Tree to Graph
a413f0f 
Make data structure more general.
@nafiz1001
use symbol for representing current node instead
4097147
@nafiz1001
use color to indicate qc flag
3094e7f
@nafiz1001
document graph constructor
0023bae
@nafiz1001
use history
cc8c210
@nafiz1001
decoupole edge with with subgraph
ec8b01f
@nafiz1001
remove React.StrictNode
d0a3d7b
@nafiz1001
100% async tree construction (wip)
e05a8e5
@nafiz1001
give up on async
210b770
@nafiz1001
reject undefined values
ab02a2a
@nafiz1001
don't throw exception
c87082a
@nafiz1001
use dagre
4137e47
@nafiz1001
add sample_lineage service and view
494014a
@nafiz1001
integrate SampleDetailsLineage with sample_lineage api
01deb57
@nafiz1001
fetch parents
ec20601
@nafiz1001
reuse pairToProcess
d8f8bbc
@UlysseFG UlysseFG requested review from ckostiw and UlysseFG May 17, 2022 19:08
@nafiz1001 nafiz1001 force-pushed the lineage-backend branch 5 times, most recently from 8fc9552 to 4d9f878 Compare May 30, 2022 13:33
@nafiz1001
Copy link
Contributor Author

Another nitpick. The clip rect for the graph doesn't align with the tab content bounds, so the graph clipping looks a bit broken.
Screen Shot 2022-05-27 at 9 33 27 AM
Screen Shot 2022-05-27 at 9 33 15 AM
Screen Shot 2022-05-27 at 9 33 04 AM

Screen Shot 2022-05-31 at 9 19 16 AM

Fixed it :D

@ckostiw
Copy link
Contributor

ckostiw commented May 31, 2022

My OCD is relieved by the fix for the clipping issue, thanks. :)

@nafiz1001 nafiz1001 force-pushed the lineage-backend branch 7 times, most recently from 8b251df to 765f67b Compare June 6, 2022 17:28
@nafiz1001
Copy link
Contributor Author

Here I go 🚀 !!

@nafiz1001 nafiz1001 merged commit 41bc53c into master Jun 6, 2022
@nafiz1001 nafiz1001 added the enhancement New feature or request label Jul 22, 2022
@nafiz1001 nafiz1001 self-assigned this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianballesteros sebastianballesteros sebastianballesteros approved these changes

@ckostiw ckostiw ckostiw approved these changes

@UlysseFG UlysseFG Awaiting requested review from UlysseFG

Assignees

@nafiz1001 nafiz1001

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nafiz1001 @sebastianballesteros @ckostiw @UlysseFG