Skip to content

Implement ElementColorProvider #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Implement ElementColorProvider #23

merged 1 commit into from
Apr 9, 2025

Conversation

FoxKiana
Copy link
Contributor

@FoxKiana FoxKiana commented Apr 6, 2025

  • added C3ElementColorProvider to display colors represented by a hexadecimal integer

Example rgb

Example argb

- added C3ElementColorProvider to display colors represented by a hexadecimal integer
@lerno
Copy link
Contributor

lerno commented Apr 9, 2025

Cool!

@lerno lerno merged commit a963624 into c3lang:master Apr 9, 2025
1 of 2 checks passed
@lerno
Copy link
Contributor

lerno commented Apr 9, 2025

There was a small issue with rgba values due to how they are handled by JBColor. I also created a way to set it, which required a workaround due to this: https://youtrack.jetbrains.com/issue/IDEA-331607/JavaColorProvider-issues

@FoxKiana
Copy link
Contributor Author

FoxKiana commented Apr 10, 2025

i encountered an issue while testing around today where the hex value was too big to be an int so i had to change the type which broke the color setter

Edit:
the value 0x99999999 is too large and needs to be explicitly cast to int which sometimes breaks the getter and setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants