Skip to content

improve tags #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

improve tags #147

wants to merge 4 commits into from

Conversation

PascalinDe
Copy link
Member

@PascalinDe PascalinDe commented Jun 24, 2025

  • use EPFL style for tags
  • orders tags alphabetically
  • remove tag from filter when clicking again on selected tag

@PascalinDe PascalinDe requested review from ineiti and lanterno June 24, 2025 14:29
@github-project-automation github-project-automation bot moved this to In progress in Engineer's TODO Jun 24, 2025
@PascalinDe PascalinDe moved this from In progress to Ready4Review in Engineer's TODO Jun 24, 2025
@ineiti
Copy link
Member

ineiti commented Jun 24, 2025

Looks nice - some comments:

  • tags on the pages look much too imposing, can you also apply the EPFL style there?
  • in the screenshot the tags are also on multiline - not sure if there is something we can do about that
  • perhaps on another issue: the "Back" button seems out of place
image

@PascalinDe
Copy link
Member Author

Looks nice - some comments:

* tags on the pages look much too imposing, can you also apply the EPFL style there?

it's the "plain" EPFL style- I thought as those are not clickable it differentiates them from the clickable ones, but I can change it to the "light" style instead

* in the screenshot the tags are also on multiline - not sure if there is something we can do about that

I'll have a look

* perhaps on another issue: the "Back" button seems out of place

yeah, the elements need better positioning, I'll add a PR later for that

@PascalinDe
Copy link
Member Author

updated to:

  • use lighter style
  • prevent text wrapping in tags
  • some more clean-up (centered text, removed unnecessary style)

@PascalinDe
Copy link
Member Author

mixed up my pull requests, closing this one opening another 😑

@PascalinDe PascalinDe closed this Jun 25, 2025
@github-project-automation github-project-automation bot moved this from Ready4Review to Done in Engineer's TODO Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants