Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table visualisation for categorical values #5012

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pozhidaevak
Copy link

Fixes #10900 (cBioPortal/cbioportal#10900)

Change description:

  • table visualization added for categorical values
  • "Plot type" renamed to visualisation type

Tests

I haven't added tests as I'm new to the project and not sure which ones are better to add. Will appreciate any guidance

Screenshots

Before

image

After

image
image

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit e4e624d
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67015e73180629000863003b
😎 Deploy Preview https://deploy-preview-5012.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pozhidaevak pozhidaevak marked this pull request as ready for review October 13, 2024 12:22
@pozhidaevak
Copy link
Author

@inodb Can you please review the change or suggest who should I ask for review?
I see that some tests are failing, but I checked other PRs and see more or less the same failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant