Muks #5153
Open
Muks #5153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#4753
([mutation diagram] zoom in and move #4753)
Description
Refactor LollipopPlot components to resolve private property access issue and improve tooltip behavior during zoom operations.
Changes
Made lollipopComponents protected in LollipopPlotNoTooltip.tsx
Added public getter methods for safe component access
Improved tooltip position updating during zoom/move operations
Maintained all existing functionality while fixing TypeScript errors
Checks
Has tests (existing tests cover lollipop functionality)
Follows commit message guidelines (single cohesive commit)
Clinical attributes (N/A - visualization change only)
Any screenshots or GIFs?
i just share you video link while doing zoom functionality(https://drive.google.com/file/d/1g4AJUCNsNWXosMf_ZHDbcyDEzEr6AK3P/view)
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR