Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/clean outdated files #112

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Chore/clean outdated files #112

wants to merge 23 commits into from

Conversation

JTaeuber
Copy link
Member

@JTaeuber JTaeuber commented Nov 14, 2024

Motivation

There were a few outdated files that were pretty much unusable before. This pr aims to clean up a bunch of outdated things and format the code accordingly.

Changes

  • Overhauled pre-commit-config.yaml to be usable and useful
  • Adjusted Makefile to have correct information
  • Fixed a bunch of python errors pointed out by pytest and mypy
  • Formatted all files
  • Fixed a few typos and changed install command to be less confusing
  • Added correct version and maintainer info
  • fixed --interval documentation value mentioned in fix(chart value): fixing interval from 60 to 30 as it's the default #109

Tests done

pytest and pre-commit ran with no errors

TODO

  • I've assigned myself to this PR
  • It needs to be tested that I didn't break any functionality

@JTaeuber JTaeuber added housekeeping dependencies Pull requests that update a dependency file labels Nov 14, 2024
@JTaeuber JTaeuber self-assigned this Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

File Coverage
All files 97%
test_autoscale_resource.py 99%
test_cmd.py 100%
test_events.py 100%
test_grace_period.py 100%
test_ignore_if_labels_dont_match.py 100%
test_main.py 100%
test_pods_force_uptime.py 100%
test_resources.py 100%
test_scaler.py 95%
test_time.py 100%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3c4202d

@JTaeuber
Copy link
Member Author

@samuel-esp It would be awesome if you could test that i didn't break any functionality. At the moment I cannot do this effectively. I know it's a lot of changes so take your time.

Copy link
Member

@jonathan-mayer jonathan-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM, but we should still test it

Makefile Outdated Show resolved Hide resolved
kube_downscaler/__init__.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants