feat/e2e-test-pipeline #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Kloeker <[email protected]>
puffitos
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM. Please open an issue regarding my reviews.
We shouldn't build a latest image in the main branch, as the main branch doesn't always need to be fully functional, and directly tagging something with latest means that it will get pulled automatically by various runtimes. The latest image (as well as a properly versioned image) should be produced when git tags are created.
|
@jonathan-mayer @JTaeuber waiting on your approval here, when you got some time. @Fovty Thanks for creating the issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
Creating a fully functional e2e pipeline
Proposal
Clone sparrow e2e pipeline and adapt it accordingly
Who can address the issue
Other links/references