Fix/cleanup-readme #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E.g. the |
|
Yes, GitHub pages will probably be the way to go. We already have a repo for helm charts: https://github.com/caas-team/helm-charts I will try to solve this asap |
|
Love it thanks.
…On Wed, Apr 17, 2024 at 1:46 PM Johannes ***@***.***> wrote:
Yes, GitHub pages will probably be the way to go. We already have a repo
for helm charts: https://github.com/caas-team/helm-charts
I will try to solve this asap
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIERWQB6JT3WBKFFTUCK2LY5ZOJ7AVCNFSM6AAAAABGKXH3UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGA3TEMJRGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Mvh. / Kind regards
Lars Bengtsson
- Health is wealth, movement is medicine -
My DevOps blog <https://bengtssondd.it>
My poetry website <https://skakmatdigte.dk>
|
puffitos
requested changes
Apr 19, 2024
Signed-off-by: Bruno Bressi <[email protected]>
|
@Fovty I've formatted the README and corrected the grammar. I don't know about renaming everything to py-kube-downscaler. The language the tool is written it seems irrelevant to its name. Either way, LGTM now 👍 |
puffitos
approved these changes
Apr 22, 2024
|
@puffitos Thank you for the review! We decided to rename the tool because the plan was to possibly write a Kubernetes dowscaler in GO in the future. |
JTaeuber
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request introduces necessary updates to the
README.mdfiles and other documentation to better align with the current deployment strategies using Helm for the project. Basic kubectl deployments -> more robust Helm-based deploymentChanges
README.mdfile has been updated to remove outdated deployment instructions and instead points users to the new Helm chart documentation.config.yaml,deployment.yaml,kustomization.yaml, andrbac.yaml) have been removed as they are no longer necessary with the transition to Helm chart deployment.TODO