Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/refine-tagging-logic #21

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Fix/refine-tagging-logic #21

merged 4 commits into from
Apr 18, 2024

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented Apr 17, 2024

Motivation

This PR addresses the issue of automatic "latest" tagging for main branch commits, which could mistakenly promote unstable builds into production. The update ensures that the "latest" tag is only applied to stable, versioned releases.

Changes

  • Removed automatic "latest" tagging from main branch commits.
  • "Latest" tag now only applies to new release tags.
  • Added logic to extract version numbers from git tags for Docker image tagging.

TODO

  • I've assigned myself to this PR.

@Fovty Fovty self-assigned this Apr 17, 2024
@Fovty Fovty requested a review from puffitos April 17, 2024 07:40
@Fovty Fovty added the enhancement New feature or request label Apr 17, 2024
@Fovty Fovty changed the title fix: refine tagging logic fix/refine-tagging-logic Apr 17, 2024
@Fovty Fovty changed the title fix/refine-tagging-logic Fix/refine-tagging-logic Apr 17, 2024
@Fovty Fovty requested a review from eumel8 April 17, 2024 08:55
eumel8
eumel8 previously approved these changes Apr 17, 2024
.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
@puffitos
Copy link
Member

Looks great. You want to adress the deprecation in this PR or would you prefer to do that in a new PR?

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

eumel8
eumel8 previously approved these changes Apr 18, 2024
@Fovty
Copy link
Member Author

Fovty commented Apr 18, 2024

I have addressed this small fix right here: 4192efa and fixed the new introduced bug here: 3031889. Now it should be fine

Looks great. You want to adress the deprecation in this PR or would you prefer to do that in a new PR?

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Copy link
Member

@puffitos puffitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issues so quickly, well done 👏

@Fovty Fovty merged commit f18cd0b into main Apr 18, 2024
2 checks passed
@Fovty Fovty deleted the fix/refine-tagging-logic branch April 18, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants