Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission adjustments & run on PRs #48

Merged
merged 1 commit into from
May 21, 2024
Merged

permission adjustments & run on PRs #48

merged 1 commit into from
May 21, 2024

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented May 21, 2024

Motivation

This change aims to fix the issue where dependabot is unable to run the GitHub Actions workflows due to insufficient permissions. By explicitly granting the necessary permissions in the workflow file, we ensure that dependabot can perform its operations without encountering permission-related errors.

Changes

  • Updated the Python Tests workflow file to include a permissions block.
  • Granted read permissions for contents and write permissions for issues, checks, and pull-requests.
  • Allow workflows to run on all pull requests

Tests done

None

TODO

  • I've assigned myself to this PR

@Fovty Fovty self-assigned this May 21, 2024
@Fovty Fovty added the enhancement New feature or request label May 21, 2024
Copy link

File Coverage
All files 97%
test_autoscale_resource.py 99%
test_cmd.py 100%
test_events.py 100%
test_grace_period.py 100%
test_ignore_if_labels_dont_match.py 100%
test_main.py 100%
test_pods_force_uptime.py 100%
test_resources.py 100%
test_scaler.py 95%
test_time.py 100%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 8d8195c

@JTaeuber JTaeuber merged commit 63b594c into main May 21, 2024
5 checks passed
@JTaeuber JTaeuber deleted the fix/pytest-workflow branch May 21, 2024 11:04
@Fovty Fovty restored the fix/pytest-workflow branch May 21, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants