Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cli config #6

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Feat/cli config #6

merged 7 commits into from
Nov 7, 2023

Conversation

y-eight
Copy link
Contributor

@y-eight y-eight commented Oct 31, 2023 •
edited
Loading

Motivation

The sparrow needs a cli configuration to pass the needed configuration parameters during startup.

Cobra is a useful library to parse cli flags and pass it to the config.

Blocked by #5

Changes

  • added cobra integration for cli flags
  • add ability to use a config file/env vars to setup sparrow
  • extend the config for http loader
  • restructure cmd dir; outsource main

@y-eight y-eight self-assigned this Nov 4, 2023
@y-eight y-eight merged commit 4aaf296 into main Nov 7, 2023
1 check passed
@lvlcn-t lvlcn-t deleted the feat/cli-config branch November 8, 2023 13:56
@lvlcn-t lvlcn-t added the feature Introduces a new feature label Dec 6, 2023
lvlcn-t pushed a commit that referenced this pull request Jan 29, 2024
@JTaeuber
feat: added new workflow to prune old images (#88)
3f5416b 
* feat: added workflow to prune old images (#1)

* fix: added runs-on variable (#2)

* feat: trying new regex (#3)

* fix: trying commit as expression (#4)

* fix: trying keep tags (#5)

* beingtoospecific (#6)

* fix: regex expression fixed (#7)

* fix: new regex (#8)

* Test (#9)

* fix: new regex

* test

* fix: fixed regex hopefully (#10)

* fix: pruning snapshots (#11)

* feat: added new workflow to prune old images for packages sparrow and charts/sparrow

* fix: removed keep-last conditions

* fix: removed comments

* fix: removed unnecessary permission declaration

* fix: removed dry-run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklastreml niklastreml niklastreml approved these changes

Assignees

@y-eight y-eight

Labels
feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-eight @niklastreml @lvlcn-t