Skip to content

Flatten python requirements 2 #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: python-rewrite
Choose a base branch
from

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Feb 20, 2024

I figured out how to use the output of a Python script during enterShell to flatten requirements and reinstall when they've changed.

It has a backwards imcompatibilty: "python.venv.requirements" now must be a string, and the string must be a devenv-root-relatvive path to a requirements file. This will break anyone who uses the option. Not sure how to signify this in the checkin without some sort of changelog file.

@domenkozar
Copy link
Member

Ideally to land this we need import-from-derivation to work well. This is kind of blocked on #1548 unless we figure out a way for requirements to still be a types.path in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants