-
Notifications
You must be signed in to change notification settings - Fork 155
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hooks: fix rome and nixfmt migrations
I've decided to go with the "duplicate the thing and move on" migration approach. Here's why: 1. `hooks.nix` doesn't operate at the submodule level. Migrations need to be added to the hooks submodule in `pre-commit.nix`, which is a bit of a mess. 2. `mkAliasOptionModule` and `mkRenamedOptionModule` work (with the above caveat). However, the former makes it impossible AFAIKT to implement warnings because of the two-way aliasing, and the latter will always spew warnings when we eval `enable`. 3. Once we split up `hooks.nix` and have each hook in a separate module, I think we can revisit hook migrations. Until then, the dumb solution is better than a half-baked smart one.
- Loading branch information
Showing
2 changed files
with
58 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters