Skip to content

Conversation

@r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Oct 23, 2024

These cause warnings with recent versions of pre-commit, and will be
removed in the future.

These cause warnings with recent versions of pre-commit, and will be
removed in the future.
Copy link
Contributor

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully tested that this PR eliminates the following pre-commit hook warning when running for example pre-commit run --all-files:

[WARNING] hook id `<HOOK>` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.

Note that running the upstream suggested pre-commit migrate-config command does not resolve the git-hooks.nix issue.

@sandydoo sandydoo added the tech-debt Internal improvements label Oct 30, 2024
@sandydoo sandydoo merged commit af8a16f into cachix:master Oct 30, 2024
4 checks passed
@sandydoo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech-debt Internal improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants