Skip to content

fix: staticcheck missing go bin when using nix flake check #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: staticcheck missing go bin when using nix flake check #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions modules/hooks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,22 @@ in
};
};
};
staticcheck = mkOption {
description = "staticcheck hook";
type = types.submodule ({ config, ... }: {
imports = [ hookModule ];
options.packageOverrides = {
go = mkOption {
type = types.package;
description = "The go package to use";
};
go-tools = mkOption {
type = types.package;
description = "The go-tools package to use";
};
};
});
};
statix = mkOption {
description = "statix hook";
type = types.submodule {
Expand Down Expand Up @@ -4018,11 +4034,18 @@ lib.escapeShellArgs (lib.concatMap (ext: [ "--ghc-opt" "-X${ext}" ]) hooks.fourm
files = "(\\.yaml$)|(\\.yml$)";
};
staticcheck =
let
inherit (hooks.staticcheck) packageOverrides;
wrapper = pkgs.runCommand "staticcheck-wrapped" { buildInputs = [ pkgs.makeWrapper ]; } ''
makeWrapper ${packageOverrides.go-tools}/bin/staticcheck $out/bin/staticcheck \
--prefix PATH : ${packageOverrides.go}/bin
'';
in
{
name = "staticcheck";
description = "State of the art linter for the Go programming language";
package = tools.go-tools;
# staticheck works with directories.
package = wrapper;
packageOverrides = { go = tools.go; go-tools = tools.go-tools; };
entry =
let
script = pkgs.writeShellScript "precommit-staticcheck" ''
Expand Down