Fix install.enable option and enable hook stage config in run derivation#689
Open
mitchallain wants to merge 6 commits intocachix:masterfrom
Open
Fix install.enable option and enable hook stage config in run derivation#689mitchallain wants to merge 6 commits intocachix:masterfrom
mitchallain wants to merge 6 commits intocachix:masterfrom
Conversation
mitchallain
commented
Feb 13, 2026
sandydoo
added
enhancement
sandydoo
requested changes
Feb 25, 2026
Member
sandydoo
left a comment
sandydoo
left a comment
There was a problem hiding this comment.
Great! Couple of small things to fix and lets merge.
Author
|
@sandydoo still interested in landing this? Should be ready for another round |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix install.enable option
this option's behavior does not match the description. Prior to this PR it bypasses building the yaml config. This PR defines a no-install branch in the
installationScriptwhich only builds and symlinks the.pre-commit-config.yamlrunHookStage option
If the user wants custom
default_stages(e.g.,pre-push) the run derivation needs an option to dictate which hook-stage gets run. This allows the user to appendmanualtodefault_stagesand then invoke the manual hook-stage.