Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update caddy 2.7.5 #142

Merged
merged 4 commits into from
Oct 16, 2023
Merged

chore: update caddy 2.7.5 #142

merged 4 commits into from
Oct 16, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Sep 19, 2023 •
edited
Loading

Changes

  • update to Caddy 2.7.5

NB: this is a rebase from #129

@mavimo mavimo changed the title Update caddy 2.7.3 Update caddy 2.7.4 Sep 19, 2023
@AaronDewes AaronDewes mentioned this pull request Sep 20, 2023
Closed
@mavimo mavimo force-pushed the AaronDewes-update-caddy-2.7.3 branch from aca4407 to 9a7c218 Compare October 7, 2023 15:42
@mavimo mavimo changed the title Update caddy 2.7.4 chore: update caddy 2.7.4 Oct 7, 2023
@mavimo mavimo self-assigned this Oct 7, 2023
This was referenced Oct 7, 2023
Merged
Merged
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@0a4bb5a). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage          ?   32.42%           
=========================================
  Files             ?       10           
  Lines             ?      293           
  Branches          ?        0           
=========================================
  Hits              ?       95           
  Misses            ?      197           
  Partials          ?        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavimo mavimo changed the title chore: update caddy 2.7.4 chore: update caddy 2.7.5 Oct 14, 2023
Embraser01
Embraser01 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Embraser01 Embraser01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was afraid that the upgrade wouldn't work because Caddy included a new proxy protocol plugin (that isn't working as well as the one we use) but we choose which plugin are included so we should be fine.

@Embraser01 Embraser01 merged commit 1e9f1d1 into master Oct 16, 2023
4 checks passed
@Embraser01 Embraser01 deleted the AaronDewes-update-caddy-2.7.3 branch October 16, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Embraser01 Embraser01 Embraser01 approved these changes

Assignees

@mavimo mavimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavimo @Embraser01 @AaronDewes