Add span attributes to tracing documentation#496
Merged
francislavoie merged 2 commits intocaddyserver:sync-docsfrom Jan 13, 2026
Merged
Add span attributes to tracing documentation#496francislavoie merged 2 commits intocaddyserver:sync-docsfrom
francislavoie merged 2 commits intocaddyserver:sync-docsfrom
Conversation
felix-hilden
changed the title
mholt
approved these changes
Jan 12, 2026
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thanks -- I think this is good. Although I just noticed that enclosing subdirectives entirely in [ ] is a little odd, since I think by default we assume that subdirectives, or lines within a directive block, are optional already.
Of course that's not new with your PR, I'm looking at line 21 as well...
No need to block this PR on that, but just something I noticed that might be worth discussing for consistency with the rest of our docs. I'm inclined to remove those [ ], maybe in another commit.
Thank you!
Author
|
Thanks! A small trouble to improve, no worries. The square brackets are now removed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to caddyserver/caddy#7269, I'm adding the corresponding documentation for setting custom span attributes. This is still work in progress, but the documentation at least specifies the desired functionality of the associated PR.