Add sample of batch executions #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimanishi
approved these changes
May 12, 2025
| }) | ||
| futures.Send(ctx, workflow.ExecuteActivity(aCtx, BatchActivity, taskID)) | ||
| } | ||
| futures.Close() |
There was a problem hiding this comment.
Do you mind adding a comment explaining what close does here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an example on how to batch start activities while holding concurrency limits
Why
Fanout use cases are common in workflows. However, current Cadence server doesn't support batch user cases well. The "correct" way to not bombard the server is to control the concurrency limits of activities so we don't experience lock contentions on mutable states.
Next
We might want to expose some APIs in client like
workflow.BatchExecuteActivityso users can easily write scaling workflow code.