Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward get_route_info and ROUTE_INFO_HEADER_KEY from backend #364

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

gabe-l-hart
Copy link
Contributor

@gabe-l-hart gabe-l-hart commented Jun 18, 2024

Still TODO:

@gabe-l-hart
Copy link
Contributor Author

NOTE to self: Use MODEL_MANAGER.get_module_backends here

@gabe-l-hart
Copy link
Contributor Author

I'm retracting my NOTE to self because using MODEL_MANAGER.get_module_backends would potentially result in different semantics if there are multiple TGISBackend instances configured.

Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gabe-l-hart gabe-l-hart merged commit 4ce8435 into caikit:main Jun 19, 2024
5 checks passed
@gabe-l-hart gabe-l-hart deleted the RouteInfoFromBackend branch June 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants