Add TGISBackend.register_model_connection() method
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
mynhardtburger
commented
Jun 5, 2024
|
@gabe-l-hart FYI |
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
mynhardtburger
force-pushed
the
register_connection
branch
from
e90da79
to
e07bb87
Compare
Signed-off-by: Mynhardt Burger <[email protected]>
mynhardtburger
commented
Jun 5, 2024
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
gabe-l-hart
requested changes
Jun 6, 2024
| """Create an instance from a connection template and a model_id""" | ||
| hostname = config.get(cls.HOSTNAME_KEY) | ||
| if hostname: | ||
| hostname = hostname.format( | ||
| **{ | ||
| assert isinstance(hostname, str) |
There was a problem hiding this comment.
Let's use an error.type_check here: https://github.com/caikit/caikit-tgis-backend/pull/55/files#diff-7ec3e3fe32d1c1cfeff9730bcc81b54236e2bf8ea37f63a8de33fc4be6359e67R43
tests/test_tgis_backend.py
Outdated
| @@ -681,6 +680,103 @@ def test_tgis_backend_config_load_prompt_artifacts(): | |||
| tgis_be.load_prompt_artifacts("buz", prompt_id1, source_files[0]) | |||
|
|
|||
|
|
|||
| def test_tgis_backend_register_model_connection(): | |||
There was a problem hiding this comment.
You might be able to consolidate these two tests with @pytest.mark.parametrize
gabe-l-hart
requested review from
tjohnson31415,
hickeyma,
alex-jw-brooks,
gkumbhat,
evaline-ju and
joerunde
as code owners
gabe-l-hart
reviewed
Jun 6, 2024
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
Signed-off-by: Mynhardt Burger <[email protected]>
gabe-l-hart
requested changes
Jun 7, 2024
caikit_tgis_backend/tgis_backend.py
Outdated
| new_conn_cfg = self._base_connection_cfg | ||
| else: | ||
| if fill_with_defaults: | ||
| new_conn_cfg = self._base_connection_cfg |
There was a problem hiding this comment.
I think this needs to be self._base_connection_cfg.copy otherwise the update below will mutate self._base_connection_cfg. Since there is nesting, it should actually probably be copy.deepcopy.
There was a problem hiding this comment.
Good catch. fixed.
Signed-off-by: Mynhardt Burger <[email protected]>
gabe-l-hart
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
TGISBackend.register_model_connection()to allow for registering a newTGISConnectionmodel connection with either the default connection, a custom provided connection, or a mixture where the custom provided connection is enhanced by populating the missing settings with those from the default connection.If the connection already exists, it does nothing.
Additionally the following refactoring was done:
TGISBackend._test_connection()TGISBackend._safely_update_state()to ensure thread safe updates to the_model_connectionsand_remote_models_cfgdictionaries.