Open
Conversation
Only send a txid:tweak object if the output_pubkeys array has at least one unspent output. Otherwise, we end up having the client download a lot of data they will never use.
The smallest outpoint is chosen from all of the transaction inputs, not just the silent payment eligible inputs (see BIP352). In practice, most wallets will be spending the same input types together so its likely that the set of silent payments eligible inputs will be the same as the set of transaction inputs. Wallets can, however, add non-eligible inputs, such as OP_CHECKMULTISIG inputs. Fix by collecting all outpoints before filtering for the silent payments eligible inputs.
70,000 is way too early, update to 800,000 which is after taproot activation and a little before the first BIP352 transactions appear on chain. Ideally, this start height should be network specific considering taproot has always been activated on signet. Leave a comment to fix this in a followup.
|
With this patch I actually got it to start looking for sp tweaks. Will see if the fully indexed daemon can be used for cake wallet when its done. I've have not managed to get the wallet to catch up with sp indexing using the provided server. |
|
Indexing took a while. Seems to work. I just scanned for SPs in desktop cake wallet using my own instance. Scanning from the client takes a while, and eats lots of resources. Haven't managed to complete scanning on my old Android phone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been doing some testing and review, here are some bug fixes/improvements. Longterm, my goal is to get the electrs fork ready for a PR to the upstream electrs rep, but no reason not to update little things as I go along.
The main change here is now clients doing long rescans will download less data since a txid and tweak will only be included in the response if it has at least one unspent output.
Also let some thoughts in the comments (mostly for myself). cc @rafael-xmr