Skip to content

Conversation

@ravage84
Copy link
Member

While working on #117, I noticed a few issues with DebugKit. Realized it was quite outdated, so the rest of the dependencies were. Updated/upgraded some, including CakePHP itself to the newest stable.

In some cases I used shortest way possible to get it working. So I guess somebody with more familiarity of the sites code should have good look at it.

Changelogs summary:

 - aura/installer-default removed (installed version was 1.0.0)

 - zendframework/zend-diactoros updated from 1.3.10 to 1.8.6
   See changes: zendframework/zend-diactoros@1.3.10...1.8.6
   Release notes: https://github.com/zendframework/zend-diactoros/releases/tag/1.8.6

 - aura/intl updated from 1.1.1 to 3.0.0
   See changes: auraphp/Aura.Intl@1.1.1...3.0.0
   Release notes: https://github.com/auraphp/Aura.Intl/releases/tag/3.0.0

 - cakephp/chronos updated from 1.0.4 to 1.2.3
   See changes: cakephp/chronos@1.0.4...1.2.3
   Release notes: https://github.com/cakephp/chronos/releases/tag/1.2.3

 - cakephp/cakephp updated from 3.3.12 to 3.6.12
   See changes: cakephp/cakephp@3.3.12...3.6.12
   Release notes: https://github.com/cakephp/cakephp/releases/tag/3.6.12

 - linkorb/jsmin-php installed in version 1.0.0
   Release notes: https://github.com/linkorb/jsmin-php/releases/tag/1.0.0

 - natxet/cssmin installed in version v3.0.6
   Release notes: https://github.com/natxet/CssMin/releases/tag/v3.0.6
Changelogs summary:

 - symfony/polyfill-ctype installed in version v1.9.0
   Release notes: https://github.com/symfony/polyfill-ctype/releases/tag/v1.9.0

 - symfony/filesystem updated from v3.2.2 to v3.4.17
   See changes: symfony/filesystem@v3.2.2...v3.4.17
   Release notes: https://github.com/symfony/filesystem/releases/tag/v3.4.17

 - symfony/polyfill-mbstring updated from v1.3.0 to v1.9.0
   See changes: symfony/polyfill-mbstring@v1.3.0...v1.9.0
   Release notes: https://github.com/symfony/polyfill-mbstring/releases/tag/v1.9.0

 - symfony/debug updated from v3.2.2 to v4.1.6
   See changes: symfony/debug@v3.2.2...v4.1.6
   Release notes: https://github.com/symfony/debug/releases/tag/v4.1.6

 - symfony/console updated from v3.2.2 to v3.4.17
   See changes: symfony/console@v3.2.2...v3.4.17
   Release notes: https://github.com/symfony/console/releases/tag/v3.4.17

 - seld/jsonlint updated from 1.5.0 to 1.7.1
   See changes: Seldaek/jsonlint@1.5.0...1.7.1
   Release notes: https://github.com/Seldaek/jsonlint/releases/tag/1.7.1

 - seld/cli-prompt updated from 1.0.2 to 1.0.3
   See changes: Seldaek/cli-prompt@1.0.2...1.0.3
   Release notes: https://github.com/Seldaek/cli-prompt/releases/tag/1.0.3

 - composer/spdx-licenses updated from 1.1.5 to 1.4.0
   See changes: composer/spdx-licenses@1.1.5...1.4.0
   Release notes: https://github.com/composer/spdx-licenses/releases/tag/1.4.0

 - composer/ca-bundle updated from 1.0.6 to 1.1.3
   See changes: composer/ca-bundle@1.0.6...1.1.3
   Release notes: https://github.com/composer/ca-bundle/releases/tag/1.1.3

 - symfony/process updated from v3.2.2 to v4.1.6
   See changes: symfony/process@v3.2.2...v4.1.6
   Release notes: https://github.com/symfony/process/releases/tag/v4.1.6

 - symfony/finder updated from v3.2.2 to v4.1.6
   See changes: symfony/finder@v3.2.2...v4.1.6
   Release notes: https://github.com/symfony/finder/releases/tag/v4.1.6

 - justinrainbow/json-schema updated from 4.1.0 to 5.2.7
   See changes: jsonrainbow/json-schema@4.1.0...5.2.7
   Release notes: https://github.com/justinrainbow/json-schema/releases/tag/5.2.7

 - composer/xdebug-handler installed in version 1.3.0
   Release notes: https://github.com/composer/xdebug-handler/releases/tag/1.3.0

 - composer/composer updated from 1.3.1 to 1.7.2
   See changes: composer/composer@1.3.1...1.7.2
   Release notes: https://github.com/composer/composer/releases/tag/1.7.2

 - cakephp/debug_kit updated from 3.6.0 to 3.9.3
   See changes: cakephp/debug_kit@3.6.0...3.9.3
   Release notes: https://github.com/cakephp/debug_kit/releases/tag/3.9.3
Changelogs summary:

 - cakedc/auth installed in version 3.0.1
   Release notes: https://github.com/CakeDC/auth/releases/tag/3.0.1

 - cakedc/users updated from 4.1.2 to 7.0.2
   See changes: CakeDC/users@4.1.2...7.0.2
   Release notes: https://github.com/CakeDC/users/releases/tag/7.0.2
Changelogs summary:

 - cakephp/debug_kit updated from 3.9.3 to 3.16.5
   See changes: cakephp/debug_kit@3.9.3...3.16.5
   Release notes: https://github.com/cakephp/debug_kit/releases/tag/3.16.5
Plus add minimal file header doc block
@yeliparra yeliparra changed the base branch from master to stage October 30, 2018 16:32
@yeliparra yeliparra merged commit 13515cd into stage Oct 30, 2018
@saeideng saeideng deleted the cakephp-3.6-upgrade branch October 30, 2018 18:26
@yeliparra
Copy link
Contributor

yeliparra commented Oct 30, 2018

Merged into stage to perform QA before deploying live.

@ravage84 bin/cake migrations migrate is working for you? On deploying is showing an error

Task Dump not found. Maybe you made a typo or a plugin is missing or not loaded? in [/var/virtual/cakephp/stage/30102018-185624/vendor/cakephp/cakephp/src/Console/Shell.php, line 326]

There is also an internal error on the admin part (view, edit projects).

BTW is stage it was pushed some deprecation fixes.

@ravage84
Copy link
Member Author

@ravage84 bin/cake migrations migrate is working for you? On deploying is showing an error

Honestly, forgot to check.

@yeliparra
Copy link
Contributor

@ravage84 we will check

@yeliparra
Copy link
Contributor

yeliparra commented Oct 31, 2018

@ravage84 fixed the issue with migrations and some other deprecated methods have been replaced, however, there is still some work to do with a couple of plugins that needs to be updated in the App. See here https://gist.github.com/yeliparra/e12d09aea6fa1ddf7d21893e94de4c57.

All have been done in stage branch.

@ravage84
Copy link
Member Author

@yeliparra thanks.

The deprecation warnings relating to the Burzum/Imagine plugin can't be resolved at the moment as it seems the website uses the most up to date version 2.1.1 :
https://github.com/burzum/cakephp-imagine-plugin/tags

One should probably raise an issue on that repo.

@ravage84
Copy link
Member Author

@yeliparra I've built on your changes to the stage branch, see #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants