update stan #1029
Merged
update stan #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
commented
Nov 17, 2024
| public function shutdown(EventInterface $event): void | ||
| { | ||
| /** @var \Cake\Controller\Controller|null $controller */ | ||
| $controller = $event->getSubject(); |
Contributor
Author
There was a problem hiding this comment.
This line either must return the controller object or throws an exception, if no subject is present. Therefore the whole nullable checks are not needed anymore.
LordSimal
force-pushed
the
5.x-update-stan
branch
from
f8077f6 to
f768205
Compare
ADmad
reviewed
Nov 17, 2024
| $connection->configName() === 'debug_kit' | ||
| || !$connection instanceof ConnectionInterface | ||
| ) { | ||
| if ($connection->configName() === 'debug_kit') { |
Member
There was a problem hiding this comment.
Hmm.. 4.x allowed the ConnectionManager to hold connection instances which did not implement ConnectionInterface, for e.g. https://github.com/UseMuffin/Webservice/blob/6376dc722529d888c4750793f0b286a8acd9fd71/src/Datasource/Connection.php#L19.
Guess we killed that in 5.0 by adding ConnnectionInterface as return type for ConnectionManager::get().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.